search

manuelroemer / Nullable

A source code only package which allows you to use .NET's nullable attributes in older target frameworks like .NET Standard 2.0 or the "old" .NET Framework.
https://www.nuget.org/packages/Nullable
MIT License
185 stars 8 forks source link

[PR] The proj files have been updated to enable SourceLink #12

Closed JTOne123 closed 4 years ago

JTOne123 commented 4 years ago

CSProj files have been updated to enable SourceLink in your nuget

[This pull request was created with an automated workflow]

I noticed that your repository and Nuget package are important for our .NET community, but you still haven't enabled SourceLink.

We have to take 2 steps: 1) Please approve this pull request and make .NET a better place for .NET developers and their debugging. 2) Then just upload the .snupkg file to https://www.nuget.org/ (now you can find the snupkg file along with the .nuget file)

You can find more information about SourceLine at the following links
https://github.com/dotnet/sourcelink https://www.hanselman.com/blog/ExploringNETCoresSourceLinkSteppingIntoTheSourceCodeOfNuGetPackagesYouDontOwn.aspx

If you are interesting about this automated workflow and how it works
https://github.com/JTOne123/GitHubMassUpdater

If you notice any flaws, please comment and I will try to make fixes manually

manuelroemer commented 4 years ago

Hey, thanks for your interest in the project!

I really like the idea of SourceLink, but I don't think that it can be applied to this project, because we're not building a traditional NuGet package which publishes compiled code. Instead, we're publishing source code directly - hence, there's no need for SourceLink, because this source code is directly compiled with the referencing project and therefore, any IDE can already debug into that code. You can verify this by creating a new project, referencing Nullable, using an attribute somewhere and then pressing F12 on that type. You'll notice that VS opens the entire source code. You can also add breakpoints there, etc.

I'm closing this PR for this reason. Feel free to comment if you have different opinions here. If there's a real reason to add SourceLink, we can easily reopen this.

(On another note: I should probably add SourceLink support for my Files library at some point - thanks for reminding me that this project exists!)