search

manuelvanrijn / bootstrap-switch-rails

A small gem for putting bootstrap-switch into the Rails asset pipeline
MIT License
58 stars 18 forks source link

Deprecation warning fixes #14

Closed nethad closed 9 years ago

nethad commented 9 years ago

Hi,

do you plan to release a new version for this gem? This would remove the deprecation warnings already fixed in master.

manuelvanrijn commented 9 years ago

Hi @nethad,

I'd like to keep the versions equal to the javascript plugin, so as soon as there's a new version :)

webhive commented 9 years ago

Hmm - it doesn't looks logical. Rails (or sass or something else) can bring some breaking changes and it will make you gem completely broken, but you will sit and wait for js plugin version change :( This is first order rails gem so IMHO should reflect rails changes too.

manuelvanrijn commented 9 years ago

@webhive this isn't a breaking change, however I just pushed version 3.3.3 with the fix.

My main goal was to reflect the version of the gem with the version of the javascript library, but that was just a thought I'm willing to let go

webhive commented 9 years ago

Thank you for update! I see your naming idea. I just think this is hard or even impossible to reflect version only of one side of gem (js) and ignore other side (rails).

nethad commented 9 years ago

@manuelvanrijn Thank you!