Closed sumitnegi7 closed 3 years ago
Path | Size |
---|---|
dist/perry.cjs.production.min.js | 24 B (0%) |
dist/perry.esm.js | 31 B (0%) |
export interface SolubilitySheet {
coldWater: Qualitative<SolubilityNature> | QuantitativeSolubility;
hotWater: Qualitative<SolubilityNature> | QuantitativeSolubility;
[key: string]: Qualitative<SolubilityNature> | QuantitativeSolubility;
}
Was not able to make coldWater and hotWater optional because of the [key:string]
is complaining about it .
export interface SolubilitySheet { coldWater: Qualitative<SolubilityNature> | QuantitativeSolubility; hotWater: Qualitative<SolubilityNature> | QuantitativeSolubility; [key: string]: Qualitative<SolubilityNature> | QuantitativeSolubility; }
export interface SolubilitySheet {
coldWater?: Qualitative<SolubilityNature> | QuantitativeSolubility;
hotWater?: Qualitative<SolubilityNature> | QuantitativeSolubility;
[key: string]?: Qualitative<SolubilityNature> | QuantitativeSolubility;
}
Try this.
export interface SolubilitySheet { coldWater: Qualitative<SolubilityNature> | QuantitativeSolubility; hotWater: Qualitative<SolubilityNature> | QuantitativeSolubility; [key: string]: Qualitative<SolubilityNature> | QuantitativeSolubility; }
export interface SolubilitySheet { coldWater?: Qualitative<SolubilityNature> | QuantitativeSolubility; hotWater?: Qualitative<SolubilityNature> | QuantitativeSolubility; [key: string]?: Qualitative<SolubilityNature> | QuantitativeSolubility; }
Try this.
(type parameter) SolubilityNature in SolubilitySheet.Qualitative
QuantitativeSolubility' only refers to a type, but is being used as a value here.ts(2693)
This works => Should i change it to this?
export interface SolubilitySheet {
coldWater?: Qualitative<SolubilityNature> | QuantitativeSolubility;
hotWater?: Qualitative<SolubilityNature> | QuantitativeSolubility;
[key: string]:
| Qualitative<SolubilityNature>
| QuantitativeSolubility
| undefined;
}
Have pushed a couple of changes to the PR
@sumitnegi7 Done with the changes. You can review once and merge if all looks okay.
Have added more inorganic compounds in local-machine will push them via a new PR after this is approved.