manufac-analytics / perry

Process Design Utilities
https://manufac-analytics.github.io/perry/
MIT License
0 stars 1 forks source link

Populate inchi dict batch1 #33

Closed sumitnegi7 closed 3 years ago

sumitnegi7 commented 3 years ago

How to verify the data =>

Search compound name or CAS no in PubChem and match the values. More info in issue #7

github-actions[bot] commented 3 years ago

size-limit report 📦

Path Size
dist/perry.cjs.production.min.js 63.98 KB (+2.9% 🔺)
dist/perry.esm.js 64.67 KB (+2.86% 🔺)
sumitnegi7 commented 3 years ago

Sir @maneetgoyal have added CAS as an optional property. It can be made mandatory too if we fill it up for all existing compounds. Is optional okay for now?

maneetgoyal commented 3 years ago

Sir @maneetgoyal have added CAS as an optional property. It can be made mandatory too if we fill it up for all existing compounds. Is optional okay for now?

Try to add it for all the compounds & make it mandatory.

saikat-samanta commented 3 years ago

looks good 👍

sumitnegi7 commented 3 years ago

Sir @maneetgoyal please check CAS has been made mandatory and added or all compounds.

sumitnegi7 commented 3 years ago

@qur786 please try to review this when you are free.

maneetgoyal commented 3 years ago

Closing it