Migrated Batch3 of Thermal Conductivity

manufac-analytics / perry

Process Design Utilities

https://manufac-analytics.github.io/perry/

MIT License

0 stars 1 forks source link

Migrated Batch3 of Thermal Conductivity #39

Closed qur786 closed 3 years ago

github-actions[bot] commented 3 years ago

size-limit report 📦

Path	Size
dist/perry.cjs.production.min.js	27.6 KB (+5.88% 🔺)
dist/perry.esm.js	28.52 KB (+5.98% 🔺)

qur786 commented 3 years ago

[ ] Formula should be updated too.

[ ] CI should be green

Formula is already updated and second line I didn't understand it ?

maneetgoyal commented 3 years ago

[ ] Formula should be updated too.

[ ] CI should be green

Formula is already updated and second line I didn't understand it ?

Formula doesn't seem updated:

Screenshot 2021-07-29 at 5 37 59 PM

CI (continuous integration tests are failing). They should PASS before you withdraw the attention of any reviewer.

Screenshot 2021-07-29 at 5 38 14 PM

qur786 commented 3 years ago

@qur786 Read the reviewers' comments thoroughly. It was clearly mentioned not to request reviews until CI is passing. I apologise for that sir . I didn't actually see that comment. And sir what to do when , CI test fails?