search

manufac-analytics / perry

Process Design Utilities
https://manufac-analytics.github.io/perry/
MIT License
0 stars 1 forks source link

feat:Migrated Batch 1 of Vapour Thermal Conductivity #69

Closed qur786 closed 2 years ago

github-actions[bot] commented 2 years ago

size-limit report 📦

Path Size
dist/perry.cjs.production.min.js 104.4 KB (+2.05% 🔺)
dist/perry.esm.js 104.78 KB (+2.13% 🔺)
qur786 commented 2 years ago

some issues :

  1. AceticAcidExtended2 tests are failing for both type of formula
  2. ButyricAcidExtended test were failing for special function but for the general function , it is passing . So I have excluded ButyricAcidExtended from speacial compounds.
qur786 commented 2 years ago

@maneetgoyal sir , test cases are failing for AceticAcidExtended2 that's why I commented it out.

maneetgoyal commented 2 years ago

@maneetgoyal sir , test cases are failing for AceticAcidExtended2 that's why I commented it out.

That's fine, try to refactor the code as suggested above for now.

maneetgoyal commented 2 years ago

@qur786 Have made some changes. Please study them and add more test cases.

maneetgoyal commented 2 years ago

@qur786 Anything else pending here? (Apart from the 2 new comments)

qur786 commented 2 years ago

@qur786 Anything else pending here? (Apart from the 2 new comments)

No sir have you looked at NaN test for acetic acid and butyric acid

maneetgoyal commented 2 years ago

have you looked at NaN test for acetic acid and butyric acid

@qur786 They are looking good. Lets address the pending comments and merge this

saikat-samanta commented 2 years ago

@qur786, tests look okay. Passing in my local system.

Screenshot_4