search

manufactured-solutions / MASA

Method of Manufactured Solutions Repository
Other
47 stars 27 forks source link

Expose pure MASA c++ interface #26

Open nicholasmalaya opened 9 years ago

nicholasmalaya commented 9 years ago

Instead of forcing user to call sets of functions, al la:

masa_init(); masa_init_param(); masa_sanity_check();

etc.

Put together the c++ interface so that all are member functions of a masa class, i.e.:

MASA foo; foo.init(); foo.init_param(); foo.sanity();

etc.

Should not be too hard. Will require reworking masa core routines, as well as wrappers for c and fortran. Also, all cpp regression tests will need fixin'.

Was requested by @pbauman and @vikramvgarg. This is not an API change but significant enough I would like it to be independent of current masa release targets (0.44). Likely will be named 0.50.

roystgnr commented 9 years ago

Why a new MASA class rather than the existing MasterMS class?

nicholasmalaya commented 9 years ago

This is not a new class -- as the title implies the intent is to expose the existing class and methods.

roystgnr commented 9 years ago

I see "MASA foo;" in the issue.

I see "namespace MASA" but not "class MASA" in the code. Where is the existing class?