manuhabitela / nautsbuilder

Playing Awesomenauts? Make your 'nauts builds and share them easily on the web
Other
23 stars 4 forks source link

Nautsbuilder not working in Steam ingame browser because of favorites #19

Closed r0estir0bbe closed 10 years ago

r0estir0bbe commented 10 years ago

When opening the Nautsbuilder in the Steam overlay browser, you simply get an empty red or blue window with the footer. Defining window.onerror reports the following Javascript error when loading the page inside the browser:

Error message: Uncaught TypeError: Cannot call method 'getItem' of null
URL: http://localhost:8000/js/lib/backbone.localStorage.js
Line Number: 43

Backbone.LocalStorage is only referenced in leiminauts.Favorites - a feature that doesn't exist anymore:

...
this.localStorage = new Backbone.LocalStorage("nautsbuilder.favorites");
...

By removing quick-and-dirty all references to leiminauts.Favorites and its views, the Nautsbuilder works almost without any problem. I suggest that the favorites features gets removed properly and thus solving this problem.

manuhabitela commented 10 years ago

Thanks for letting me know - should be better now.