I made a clean new approach, change as little as i can.
This should be all that is needed to work with simple-ember-auth. ( one pull request without touching the email settings ( will be next ) )
I think the correct "functional programming" way is to create a new function with the correct params ( as opposed to creating ifs and elses ).
What do you think ? Is the refactor branch the correct one ?
alexjp
commented
9 years ago
Hi,
I made a clean new approach, change as little as i can. This should be all that is needed to work with simple-ember-auth. ( one pull request without touching the email settings ( will be next ) ) I think the correct "functional programming" way is to create a new function with the correct params ( as opposed to creating ifs and elses ).
What do you think ? Is the refactor branch the correct one ?