manulaiko / Kalaazu

The next generation of DarkOrbit Private Servers
23 stars 4 forks source link

Magic numbers #1

Open meinder-a opened 4 years ago

meinder-a commented 4 years ago

Hi Manu :) What a great project, that's very cool to see a different way to create a DarkOrbit Private Server

I've seen many magic numbers tho, you should avoid using these because of code complexity.

https://github.com/manulaiko/Kalaazu/blob/4d3833bc8d6ee799187fb5fc634144b6e8bd1b1b/CMS/src/main/java/com/kalaazu/cms/service/RegisterService.java#L188

-NoCheatImPGM

manulaiko commented 4 years ago

The idea is to move the initial items to a configuration file rather than hardcoding it in the near future.

Thing is that with studies and work I barely have time.

meinder-a commented 4 years ago

That's cool :) Good luck!

akxks commented 3 years ago

Can someone help me make a private darkorbit server with the original website and all resources ?? Exact replica / near replica and emulation ???