search

manups4e / ScaleformUI

ScaleformUI is a GTA menu styled API made with custom Scaleforms to be lighter, faster and visually better
Other
141 stars 49 forks source link

Open & close spam breaks menu #156

Closed ross1296 closed 1 year ago

ross1296 commented 1 year ago

Can produce a video if need be, but here's the reproduction steps:

1) Draw a marker anywhere in the game world 2) Create a menu 3) Add logic to that marker, that when you're standing inside of it you can click 'E' or another key to open the menu 4) Make sure that you do if IsControlJustPressed(1, 86) and not MenuHandler:IsAnyMenuOpen() then inside of the thread for the marker 4) Stand inside of the marker and spam 'E' and backspace

It would appear that during the open and close menu spam that the MenuHandler thinks that its open, when in reality nothing shows on the screen. Then, you cannot open the menu from the blip because of not MenuHandler:IsAnyMenuOpen()

manups4e commented 1 year ago

😅 my first question is why would u be spamming open / close the menu.. ahahah but yeah I'll investigate this

ross1296 commented 1 year ago

😅 my first question is why would u be spamming open / close the menu.. ahahah but yeah I'll investigate this

Never underestimate the end user :)

Local9 commented 1 year ago

Or the developer who doesn't add in a rest period, this is likely an edge case.

manups4e commented 1 year ago

fixed with https://github.com/manups4e/ScaleformUI/commit/e5e830f2c8e7a172dfb91bf6fe1ff87cbd54d54f