manups4e / ScaleformUI

ScaleformUI is a GTA menu styled API made with custom Scaleforms to be lighter, faster and visually better
Other
147 stars 49 forks source link

Menu header CounterPretext #27

Closed jtriclin closed 2 years ago

jtriclin commented 2 years ago

The CounterPretext variable is present in the UIMenu script for both CSharp and Lua, but is unusable as of now. It might be useful to add support for it to allow updating the color of the counter.

/// <summary>
/// String to pre-attach to the counter string. Useful for color codes.
/// </summary>
public string CounterPretext { get; set; }
manups4e commented 2 years ago

what do you mean the color of the counter?

jtriclin commented 2 years ago

At the moment, the counter (1/X right of the subtitle) color is blue and cannot be changed. In NativeUI, you were able to change it using the CounterPretext variable. In your current version, the variable is still present but is never used.

https://github.com/manups4e/ScaleformUI/blob/4403c90d6f51d70acd6901ab84fd4a6c34c0e2ae/ScaleformUI_Csharp/UIMenu.cs#L2656

manups4e commented 2 years ago

oh i see.. so you want to change the color right? i'll add a CounterColor variable for that :)

manups4e commented 2 years ago

the CounterPretext is not necessary for Scaleforms so i'll remove it..

jtriclin commented 2 years ago

Exactly, Thanks !