Document `start args` parameter

manusa / actions-setup-minikube

Set up your GitHub Actions workflow with a specific version of Minikube and Kuberentes

Apache License 2.0

62 stars 26 forks source link

Document `start args` parameter #41

Open omus opened 3 years ago

omus commented 3 years ago

After looking through the code I noticed startArgs: https://github.com/manusa/actions-setup-minikube/blob/965c2006a2cf6c24971b6419ccacf46a2c1b0065/src/install.js#L25-L27 It would be great if this features was documented as some minikube features like --cni have to be set during minikube start

manusa commented 3 years ago

Hi @omus, There's already documentation about this in the Optional input parameters section. However, if you missed it, it's probably not in the best place, or missing emphasis. Do you have any suggestions to improve this?

omus commented 3 years ago

Wow, I'm not sure how I missed that...

I think where it's located in the documentation is fine but I would make minikube start link to https://minikube.sigs.k8s.io/docs/commands/start/