search

manusa / actions-setup-minikube

Set up your GitHub Actions workflow with a specific version of Minikube and Kuberentes
Apache License 2.0
60 stars 25 forks source link

Upgrade cri-dockerd version to fix a bug that can not download large images #77

Closed tenzen-y closed 12 months ago

tenzen-y commented 1 year ago

Signed-off-by: tenzen-y yuki.iwai.tz@gmail.com

The cri-dockerd v0.2.0 has a critical bug that can not download large container images. And it was resolved in v0.2.6.

ref:

manusa commented 1 year ago

Nice! The asset filtering needs to be tuned since now the Linux artifact no longer contains linux in its name. I'll change this if I can later today (feel free to do so yourself if I haven't responded in a few hours).

tenzen-y commented 1 year ago

Nice! The asset filtering needs to be tuned since now the Linux artifact no longer contains linux in its name.

Thanks for the review!

I'll change this if I can later today (feel free to do so yourself if I haven't responded in a few hours).

Thanks for your effort!

tenzen-y commented 1 year ago

@manusa Thanks for improving a mechanism to install cri-dockerd!

manusa commented 1 year ago

@manusa Thanks for improving a mechanism to install cri-dockerd!

still WIP ;)

tenzen-y commented 1 year ago

@manusa Thanks for improving a mechanism to install cri-dockerd!

still WIP ;)

:_(

manusa commented 1 year ago

Unfortunately Minikube's support for cri-dockerd v0.2.6 is not there yet (https://github.com/kubernetes/minikube/issues/14724).

I'm trying to figure out a proper way to setup cri-dockerd with a cni plugin, but still no luck.

I'm also not sure if the problems with the ingress and registry extensions are related to this, or to something else.

tenzen-y commented 1 year ago

Unfortunately Minikube's support for cri-dockerd v0.2.6 is not there yet (kubernetes/minikube#14724).

I'm trying to figure out a proper way to setup cri-dockerd with a cni plugin, but still no luck.

I'm laso not sure if the problems with the ingress and registry extensions are related to this, or to something else.

@manusa Thanks for clarifying. Maybe, we need to wait for releasing version included https://github.com/kubernetes/minikube/pull/14827.

manusa commented 12 months ago

Upgrading cri-docker required the update of the complete ecosystem.

After waiting multiple months for everything to work, it seems that the dependency combination provided in #95 does the trick.

Your commit was cherry-picked into that PR, will merge that one while closing this one.

Thx for your contribution.

tenzen-y commented 12 months ago

Upgrading cri-docker required the update of the complete ecosystem.

After waiting multiple months for everything to work, it seems that the dependency combination provided in #95 does the trick.

Your commit was cherry-picked into that PR, will merge that one while closing this one.

Thx for your contribution.

Thank you for your hard work!