manuzhang / mkdocs-htmlproofer-plugin

A MkDocs plugin that validates URL in rendered html files
MIT License
43 stars 16 forks source link

Improve performance #27

Closed garrettheel closed 3 years ago

garrettheel commented 3 years ago

This introduces a number of performance improvements to help make this plugin feasible for larger documentation sets.

Performance:

Features:

Other:

manuzhang commented 3 years ago

LGTM. @johnthagen please take a look as well.

garrettheel commented 3 years ago

@johnthagen let me know if you have any questions/concerns! I was looking to submit a few additional config options after this lands too

johnthagen commented 3 years ago

@garrettheel Sorry for the delay. I haven't had time to look at this yet. Hopefully can this week, otherwise if @manuzhang thinks it's good please don't feel the need to have to wait for me.

garrettheel commented 3 years ago

@johnthagen this should be ready to go from my end

one thing I noticed was that docs/index.md duplicates most of README.md and will become out of date. would it make sense put something more generic in there as a test, rather than the actual docs? or move it to a directory name that indicates that it's used only for testing

johnthagen commented 3 years ago

@manuzhang set up that originally, but I do agree that it would make sense to have the test's be isolated from the real docs. That would allow the test project to focus specifically on the items we wish to test.

garrettheel commented 3 years ago

@manuzhang set up that originally, but I do agree that it would make sense to have the test's be isolated from the real docs. That would allow the test project to focus specifically on the items we wish to test.

Cool, I'm happy to change that here if you like. Otherwise we can handle that in a follow-up

johnthagen commented 3 years ago

@garrettheel Thank you for being willing to help out. Let's make a follow on issue for that so we can review it in pieces.

garrettheel commented 3 years ago

@johnthagen no worries! I don't have write access so you'll have to merge for me when you're ready :)

johnthagen commented 3 years ago

@garrettheel I don't have write access either, I just contributed a few PRs. @manuzhang Will need to do the final review/merge.

garrettheel commented 3 years ago

Whoops, my bad. @manuzhang when you get a chance please take another look :)

manuzhang commented 3 years ago

@garrettheel @johnthagen thanks guys. Merged.