search

manuzhang / mkdocs-htmlproofer-plugin

A MkDocs plugin that validates URL in rendered html files
MIT License
43 stars 16 forks source link

Check if targets of links "out of root" exists #59

Closed kolibri91 closed 1 year ago

kolibri91 commented 1 year ago

TBD

Closes #58

johnthagen commented 1 year ago

Handle python 3.6 with mkdocs < 1.4

In my opinion Python 3.6 is end of life and we should simply drop it from the test suite. Even Python 3.7 is almost end of life (2 months).

kolibri91 commented 1 year ago

Handle python 3.6 with mkdocs < 1.4

In my opinion Python 3.6 is end of life and we should simply drop it from the test suite. Even Python 3.7 is almost end of life (2 months).

* https://endoflife.date/python

It's not up to me to decide...

johnthagen commented 1 year ago

@manuzhang Would you have any issues with dropping Python 3.6 support since that is end of life?

manuzhang commented 1 year ago

@manuzhang Would you have any issues with dropping Python 3.6 support since that is end of life?

No, but let's do it in a separate PR and update test workflows, README, etc.

kolibri91 commented 1 year ago

Considering the results and the loss of strict mode, I would say this is not an improvement.

The only useful commit is 32f9c3efcf21fde64d3d05617a6b8678abdc69f9 and this has to be contributed in a separate PR including tests.