search

manwar / theweeklychallenge

The Weekly Challenge - Perl & Raku. You do not have to be an expert. https://theweeklychallenge.org
Artistic License 2.0
11 stars 19 forks source link

Challenge 25 Execution Time #24

Closed Doomtrain14 closed 3 years ago

Doomtrain14 commented 4 years ago

In Challenge 25, I think it is worth to note that Adam Russell's solution returned only 14 pokemon names from the list. (Not sure if I ran the script correctly or missed anything)

machamp-petilil-lunatone-exeggcute-emboar-registeel-loudred-darmanitan-nosepass-simisear-rufflet-tyrogue-emolga-audino 105

manwar commented 4 years ago

I am tagging @kianmeng for the comment :-)

kianmeng commented 4 years ago

@Doomtrain14 You're correct and it seemed to be returning 14 items. Good catch!

$ time perl challenge-025/adam-russell/perl5/ch-1.pl 
machamp-petilil-lunatone-exeggcute-emboar-registeel-loudred-darmanitan-nosepass-simisear-rufflet-tyrogue-emolga-audino 105

real    0m0.568s
user    0m0.560s
sys     0m0.008s

Tagging @adamcrussell. Adam, you want to update and fix the code to get the maximum number of chain, which is 23 names?

adamcrussell commented 4 years ago

Sure! Based on my (tired?) reading of the problem statement I was trying to maximize number of characters in the names and not path length. I’ll make a change. Surely it’ll be just nearly as fast though.

Need a little time to do this, maybe not until late tonight or tomorrow.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Kian Meng Ang notifications@github.com Sent: Monday, September 23, 2019 9:12:58 AM To: manwar/perlweeklychallenge perlweeklychallenge@noreply.github.com Cc: Adam Russell ac.russell@live.com; Mention mention@noreply.github.com Subject: Re: [manwar/perlweeklychallenge] Challenge 25 Execution Time (#24)

@Doomtrain14https://github.com/Doomtrain14 You're correct and it seemed to be returning 14 items. Good catch!

$ time perl challenge-025/adam-russell/perl5/ch-1.pl machamp-petilil-lunatone-exeggcute-emboar-registeel-loudred-darmanitan-nosepass-simisear-rufflet-tyrogue-emolga-audino 105

real 0m0.568s user 0m0.560s sys 0m0.008s

Tagging @adamcrussellhttps://github.com/adamcrussell. Adam, you want to update and fix the code to get the maximum number of chain, which is 23 names?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/manwar/perlweeklychallenge/issues/24?email_source=notifications&email_token=AAC5AEJIDG6LHLV3SNXEGS3QLC6FVA5CNFSM4IZILQL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7KZXCQ#issuecomment-534092682, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAC5AEKZS4NWF66FGA6XITTQLC6FVANCNFSM4IZILQLQ.

manwar commented 3 years ago

Hopefully it is safe to close by now.