search

manybabies / mb1-analysis-public

ManyBabies1 analysis code for public sharing
MIT License
6 stars 15 forks source link

lme4 versioning #1

Closed mcfrank closed 5 years ago

mcfrank commented 5 years ago

Note that convergence pruning for this draft was done with lme4 v1.1-13, but with versions 1.1-19, @angelinetsui reports singularity (but not convergence) warning. minimally we need to set up some version compliance for the ms, but it's also possible we should think about updating the pruning for the final version.

thoughts @christinabergmann @mekline @melsod?

christinabergmann commented 5 years ago

To begin with, we should note the version in the final MS and add some language to the code about versioning and possible effects thereof. I am not sure we need to update the model in the paper, but remain neutral on this issue (my main counter argument is to avoid additional rounds of review due to changing stats, because the analyses were done correctly given the available version).

mcfrank commented 5 years ago

I have updated the model and noted the version in the ms.