Open AddAndy opened 2 months ago
Full recursion is disabled because of zip bomb attacks, but we could probably set a maximum number of levels; I'll see what libarchive allows.
That would be great! even if it was settable in the settings (default 0, but could go up to say 3 or 4)
I was wrong about it being disabled in libarchive, that was something else; so I can add this as a feature. Nice idea to add a setting.
How would nested zips be treated by default? Should they be separate models?
I don’t think I’ve ever seen one with more than 2 levels of zips
On Tue, Aug 6, 2024 at 9:27 AM James Smith @.***> wrote:
I was wrong about it being disabled in libarchive, that was something else; so I can add this as a feature. Nice idea to add a setting.
How would nested zips be treated by default? Should they be separate models?
— Reply to this email directly, view it on GitHub https://github.com/manyfold3d/manyfold/issues/2488#issuecomment-2271568506, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADBCUZXPANLEPUIZCMJCL3ZQDTOLAVCNFSM6AAAAABL577U5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZRGU3DQNJQGY . You are receiving this because you authored the thread.Message ID: @.***>
Is your feature request related to a problem? Please describe. When uploading via the web interface; if the zip file contains nested zip files they'll be ignored
Describe the solution you'd like when uploaded a file that contains nested zips, it would be good to recursively unzip until all files are decompressed
Describe alternatives you've considered right now i need to open the archive, unzip everything then rezip as flat as possible for upload
Additional context Add any other context or screenshots about the feature request here.