search

manykarim / robotframework-doctestlibrary

Robot Framework DocTest library. Simple Automated Visual Document Testing.
Apache License 2.0
46 stars 20 forks source link

Compare Images contains_barcodes=${true} #35

Closed extmme closed 9 months ago

extmme commented 2 years ago

Hello,

I have more questions today :) I compared two different pdf files and they include a barcodes. I used the argument contains_barcodes=${true} which it should exclude the barcodes from comparing. My question is: Was the barcode excluded or was not? Because I can see the red areas even on the barcode.

Please check the picture below

barcodes

manykarim commented 2 years ago

No, it seems like the barcode was only compared visually (and the comparison failed due to visual differences). Funny, I thought that feature is a secret 🤣

In my company, only a special kind of barcode was used in the documents (a datamatrix, see https://en.wikipedia.org/wiki/Data_Matrix). So I used a library which can identify Data Matrices. I did not look much into other barcode types.

Could you provide a sample document with such a barcode?

By the way: Do you know the Slack Channel from Robot Framework? https://robotframework.slack.com/

We can discuss things there more easily. There is also a sub-channel for my library

manykarim commented 2 years ago

I will investigate if other barcode types can be added

extmme commented 2 years ago

Thank you for links.

Is enough to send you only the barcodes like pictures (the same as I sent it first time) or would you prefer the pdf?

I am aware about the Slack but haven't had to use it yet. I need to create another account...

manykarim commented 2 years ago

Sure no problem. Please send either the.pdf or a .PNG of the file (so that barcode is readable) My email address is visible on the pypi site for the robotframework-doctestlibrary

extmme @.***> schrieb am Mo., 10. Jan. 2022, 15:05:

Thank you for links

May I send you the PDF via e.mail please?

I am aware about the Slack but haven't had to use it yet. I need to create another account...

— Reply to this email directly, view it on GitHub https://github.com/manykarim/robotframework-doctestlibrary/issues/35#issuecomment-1008904145, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOTUE3DX2IIQYXKDXL4VTODUVLRTLANCNFSM5LO6OWXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

manykarim commented 9 months ago

Can be closed, as other Barcode Types have been implemented with Release https://github.com/manykarim/robotframework-doctestlibrary/releases/tag/v0.10.0

Test data here https://github.com/manykarim/robotframework-doctestlibrary/blob/main/utest/testdata/sample_barcodes.pdf