manykarim / robotframework-doctestlibrary

Robot Framework DocTest library. Simple Automated Visual Document Testing.
Apache License 2.0
48 stars 21 forks source link

Blue part does not recognized. result is passed #49

Open nixuewei opened 2 years ago

nixuewei commented 2 years ago

locator2locator1

Blue part does not recognized. result is passed Compare Images locator.png locator1.png move_tolerance=5 image

manykarim commented 2 years ago

Let's discuss the expected behavior. My impression is

manykarim commented 2 years ago

Something like that would be more accurate image

manykarim commented 2 years ago

The reason why it is - at the moment - accepted as a difference is: There is a default tolerance defined, when searching for moved image parts. It is defined here def find_partial_image_position(self, img, template, threshold = 0.1): It seems like the default value 0.1 is too high. It would fail for a lower value like 0.01 . I will think about a good compromise here..

nixuewei commented 2 years ago

@manykarim ok. thank you for your quick reply and smart understanding and I am more confident to use this software to solve our work challenges. please try to fix on next release. thanks

manykarim commented 2 years ago

By the way: As your main use case seems to be visual test of web applications, maybe the following library is also interesting: https://tesena-smart-testing.github.io/WatchUI/

nixuewei @.***> schrieb am Sa., 3. Sept. 2022, 03:14:

@manykarim https://github.com/manykarim ok. thank you for your quick reply and smart understanding and I am more confident to use this software to solve our work challenges. please try to fix on next release. thanks

— Reply to this email directly, view it on GitHub https://github.com/manykarim/robotframework-doctestlibrary/issues/49#issuecomment-1236016070, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOTUE3AOKCTWZEAXL75Y34TV4KRA3ANCNFSM6AAAAAAQDIZ4C4 . You are receiving this because you were mentioned.Message ID: @.***>

nixuewei commented 1 year ago

Ok let me try watch ui

manykarim commented 1 year ago

I also found the root cause why the different screenshots are considered matching when using move tolerance. But fix will take a bit of time..

nixuewei @.***> schrieb am So., 9. Okt. 2022, 15:23:

Ok let me try watch ui

— Reply to this email directly, view it on GitHub https://github.com/manykarim/robotframework-doctestlibrary/issues/49#issuecomment-1272542183, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOTUE3A3563S6Q3N2JZNF3DWCLBNRANCNFSM6AAAAAAQDIZ4C4 . You are receiving this because you were mentioned.Message ID: @.***>

nixuewei commented 1 year ago

yes. understand. please take your time. thanks