Fixed threshold comparison for identical matches (min_val =0.0)

manykarim / robotframework-doctestlibrary

Robot Framework DocTest library. Simple Automated Visual Document Testing.

Apache License 2.0

48 stars 21 forks source link

Fixed threshold comparison for identical matches (min_val =0.0) #89

Closed simonmeggle closed 8 months ago

simonmeggle commented 8 months ago

I tested the image comparison with a template image PDF which is a cropped version of the original PDF. In that case, I have a perfect match with min_val is at 0.0. If I set a threshold of 0.0 (= PASS only if there is an exact match) the test fails. The fix is to compare with "minor or equal" threshold.

simonmeggle commented 8 months ago

Closing this, I have refactored the code and will create another PR.