Fix `connect` and `connectTLS` and missing export

manyuanrong / deno-smtp

SMTP implements for deno

MIT License

78 stars 26 forks source link

Closed cbioley closed 4 years ago

cbioley commented 4 years ago

CI failed again, I know ;)

thr-eki commented 4 years ago

Hello,

Any plans on merging this branch ? No breaking changes here, on the contrary, the project is unusable as is.

sriio commented 4 years ago

@cbioley : You miss to change the connectTLS method (we can't use auth with tls despite this PR)

Actual : async connectTLS(config: ConnectConfig) { ...

Needed : async connectTLS(config: ConnectConfig | ConnectConfigWithAuthentication) { ...

cbioley commented 4 years ago

@sriio Thanks 👍

femave commented 4 years ago

Hope you merge it as soon as posible! GJ

pzi commented 4 years ago

Sadly it is un-useable without those types :( Please 🚢 it :)