search

manywho / ui-bootstrap

5 stars 3 forks source link

FLOW-1444 - Preventing clientside validation from firing when compone… #127

Closed jamesbrattBoomi closed 4 years ago

jamesbrattBoomi commented 4 years ago

…nt has mounted

Removed code for setting the datetime input components contentValue. Typically we would only need to change the components state when there is some kind of user interaction with the component. Altering the component state when the component initially renders is what is causing the validation side effect.

It seems that there is no issue with setting the date picker widgets value to null (we actually do this during the componentDidUpdate method anyway). As for the dates marked as invalid inside of the isEmpty function, the engine accepts these as valid dates, so I'm not sure why we need to do this.

Slightly concerned about removing anything from this component... but would rather not implement some hacky workaround.

jamesbrattBoomi commented 4 years ago

@TomFullalove Testing the ticket for the previous fix is a good idea