search

manywho / ui-bootstrap

5 stars 3 forks source link

FLOW-2001 - Removed outcome update function stopping page conditions … #154

Closed TomFullalove closed 4 years ago

TomFullalove commented 4 years ago

…changing props on a rendered outcome

TomFullalove commented 4 years ago

The ui-bootstrap fix is needed because clicking the "trash" icon deletes a rule/operation by going out to an operator and coming back to the page. This means that the components on the page are set to "update" in React with their new props. We've seen quite a lot before that some components just don't "update", they only work when initially rendered or un-rendered fully (by going to a new screen) and rendering again (by then coming back). The fix in ui-bootstrap makes the button component that I want to make sure "updates" to enabled/disbaled when they click delete on a rule/operation actually update correctly.

In short, WITHOUT this, clicking the "trash" icon to delete a rule/operation won't update the button enabled status at all, it'll stay what it was before. Adding/editing rules/operations will work though.