search

manzanotti / geniushub-client

Python library to provide direct connectivity to Genius Hub.
MIT License
9 stars 5 forks source link

Run on github action on 'main' branch, not just 'master' #72

Closed rbubley closed 1 year ago

manzanotti commented 1 year ago

As interesting as some of your previous commits on this branch are (seriously, I like the monitoring saving data, that's something I want to add to the Home Assistant plugin at some point), I'd rather not have the commits polluting the git history, even though you've reversed the commits.

I've created a PR with your change, and merged it in though, so thank you!

rbubley commented 1 year ago

Point noted. I accident merged from the wrong branch.

GitHub's Squash and Merge, for PRs is a great boon for such messy pull requests, obviating the need to worry about this sort of thing, and keeping the commit history clean.