manzinello / mailgo

💌 mailgo, a new concept of mailto and tel links [deprecated]
https://mailgo.dev
MIT License
1.03k stars 51 forks source link

Dark theme is not supported with direct render. #97

Closed yoavaviram closed 3 years ago

yoavaviram commented 3 years ago

I am the following configuration:

var window.mailgoConfig = {
  dark: true,
  details: {
    subject: false,
    body: false,
    to: false,
    cc: false,
    bcc: false,
  },
};

However the dark theme option has no affect.

manzinello commented 3 years ago

I think that you have to use

window.mailgoConfig = {
  dark: true,
  details: {
    subject: false,
    body: false,
    to: false,
    cc: false,
    bcc: false,
  },
};

window is a global object, you have not to define it with var. Please, check this example (https://github.com/manzinello/mailgo/blob/master/examples/index.windowconfig.html). If something is not working let me know!

manzinello commented 3 years ago

Re-open this, you are right, also testing without var it is not working. Thank you. I have to work on this.

manzinello commented 3 years ago

I have already work on a solution for this. I have to test it and it will be in the next release. Thank you.

yoavaviram commented 3 years ago

Any idea when the next release is due?

Hope you have a happy new year!

manzinello commented 3 years ago

Happy new year!

I think I will release a new version of mailgo this week!

manzinello commented 3 years ago

I'm sorry, I am a bit in late with the release because I am also working on a completely new mailgo.dev (updated to Docusarus 2), I am working hard, I will try to release everything in this week.

yoavaviram commented 3 years ago

Happy new year! no worries, thanks for the effort.

manzinello commented 3 years ago

Fixed in the latest version of mailgo! If something is now working please re-open this issue!