manzt / quak

a scalable data profiler
https://manzt.github.io/quak/
MIT License
201 stars 9 forks source link

Dual Scrolling in Visual Studio Code #27

Closed dakoop closed 1 month ago

dakoop commented 1 month ago

In VSCode Jupyter notebooks (macOS), the scroll event seems to be consumed by both the notebook and the table, leading to difficult scrolling interactions since the notebook is moving while trying to scroll the table. This is not an issue in JupyterLab.

quak: 0.1.2 OS: macOS 14.5 VSCode: 1.9.1 VSCode Jupyter: v2024.6.0 JupyterLab: 4.2.4

manzt commented 1 month ago

I'm aware of some prior issues with scroll behavior for widgets in VS Code, however, it seems like they are resolved or at least the insiders version worked for this individual a few months ago.

Perhaps we need to stop propagation for scroll events. I'm preparing for a meeting with my PhD committee, so I won't have time to look further until maybe next week.

dakoop commented 1 month ago

Sure. Just wanted to log a few issues I noticed when testing quak out before I forgot about them

manzt commented 1 month ago

Same issue in Positron IDE.

manzt commented 1 month ago

Should be fixed in v0.1.5. Let me know if something isn't working!