mao-santaella-rs / NightWolfTheme

🐺 Night Wolf, VsCode Theme by Mao
MIT License
36 stars 8 forks source link

Dark css hsl() colors are unreadable in night wolf (dark). #42

Closed hansschuijff closed 1 year ago

hansschuijff commented 2 years ago

I use color theme Nigh Wolf Black in vscode and I like it very much. There is just one issue for me, when I code css. When I use the hsl color defs with dark colors it becomes unreadable since the background of the text changes to the color but the font color in the css stays black. Other definitions make the font lighter so it stays readable, but not hsl().

So if I say something like: hsl(0, 0%, 0%) it completely disappears on me and I have change the def to the # color value or rgb or something to make it readable again.

Perhaps something that can be changed? Hope so.

mao-santaella-rs commented 1 year ago

Hi @hansschuijff thanks for taking the time to make this issue, the theme is in charge of giving texts colors based on the type of value, so in this case the theme gives the inside values of the hsl a kind of orange color
Screenshot 2023-03-18 at 7 55 45 PM so when you use an extension to give styles to the colors like Color Highlight the extension is in charge to give these colors based on the value of the hsl.

let me know if you have any other questions, thanks again.