#174 fix importing from packages in monorepos that need mutliple levels of node module directories

[bdwain]

fix #174.

[maoberlehner]

Hey @bdwain, thank you for your contribution. CI is failing though – I've restarted the build to see if maybe something was temporary wrong with Travis (because it was a strange error) – but if it keeps failing, please take a look at why it is happening. Thank you very much!

[bdwain]

Hi @maoberlehner this same issue happened for me on master. I can look but I’m not sure what was causing it.

[maoberlehner]

Just triggered a CI run with the master branch (https://travis-ci.org/maoberlehner/node-sass-magic-importer/builds/402112995).

Please try to change the following line:

- const packagePath = path.dirname(findupSync(packageSearchPath));
+ const packagePath = path.dirname(findupSync(packageSearchPath, { cwd: options.cwd }));

[bdwain]

@maoberlehner thanks i fixed that

[bdwain]

FYI when i run npm test on master i get

RUNS  test/bugfix/165/resolve-from-parent.test.ts
FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal.
 1: node::Abort() [/usr/local/bin/node]
 2: node::FatalTryCatch::~FatalTryCatch() [/usr/local/bin/node]
 3: v8::V8::ToLocalEmpty() [/usr/local/bin/node]
 4: CallbackBridge<Sass_Import**, void*>::operator()(std::__1::vector<void*, std::__1::allocator<void*> >) [/Users/bwain/dev/node-sass-magic-importer/node_modules/node-sass/vendor/darwin-x64-59/binding.node]
 5: sass_importer(char const*, Sass_Importer*, Sass_Compiler*) [/Users/bwain/dev/node-sass-magic-importer/node_modules/node-sass/vendor/darwin-x64-59/binding.node]
 6: Sass::Context::call_loader(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, Sass::ParserState&, Sass::Import*, std::__1::vector<Sass_Importer*, std::__1::allocator<Sass_Importer*> >, bool) [/Users/bwain/dev/node-sass-magic-importer/node_modules/node-sass/vendor/darwin-x64-59/binding.node]
 7: Sass::Context::call_importers(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, Sass::ParserState&, Sass::Import*) [/Users/bwain/dev/node-sass-magic-importer/node_modules/node-sass/vendor/darwin-x64-59/binding.node]
 8: Sass::Parser::parse_import() [/Users/bwain/dev/node-sass-magic-importer/node_modules/node-sass/vendor/darwin-x64-59/binding.node]
 9: Sass::Parser::parse_block_node(bool) [/Users/bwain/dev/node-sass-magic-importer/node_modules/node-sass/vendor/darwin-x64-59/binding.node]
10: Sass::Parser::parse_block_nodes(bool) [/Users/bwain/dev/node-sass-magic-importer/node_modules/node-sass/vendor/darwin-x64-59/binding.node]
11: Sass::Parser::parse() [/Users/bwain/dev/node-sass-magic-importer/node_modules/node-sass/vendor/darwin-x64-59/binding.node]
12: Sass::Context::register_resource(Sass::Include const&, Sass::Resource const&) [/Users/bwain/dev/node-sass-magic-importer/node_modules/node-sass/vendor/darwin-x64-59/binding.node]
13: Sass::File_Context::parse() [/Users/bwain/dev/node-sass-magic-importer/node_modules/node-sass/vendor/darwin-x64-59/binding.node]
14: sass_compiler_parse [/Users/bwain/dev/node-sass-magic-importer/node_modules/node-sass/vendor/darwin-x64-59/binding.node]
15: sass_compile_context(Sass_Context*, Sass::Context*) [/Users/bwain/dev/node-sass-magic-importer/node_modules/node-sass/vendor/darwin-x64-59/binding.node]
16: render_file_sync(Nan::FunctionCallbackInfo<v8::Value> const&) [/Users/bwain/dev/node-sass-magic-importer/node_modules/node-sass/vendor/darwin-x64-59/binding.node]
17: Nan::imp::FunctionCallbackWrapper(v8::FunctionCallbackInfo<v8::Value> const&) [/Users/bwain/dev/node-sass-magic-importer/node_modules/node-sass/vendor/darwin-x64-59/binding.node]
18: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&)) [/usr/local/bin/node]
19: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) [/usr/local/bin/node]
20: v8::internal::Builtin_Impl_HandleApiCall(v8::internal::BuiltinArguments, v8::internal::Isolate*) [/usr/local/bin/node]
21: 0x21f6563842fd
22: 0x21f65643d196
Abort trap: 6

[coveralls]

Coverage remained the same at 100.0% when pulling 8b5df86a0e50dfd559a978e77f5e86c37f5646f2 on bdwain:hotfix/fix-nested-package-imports into 84644b4f9616406f41deac0d13e6a7d13f31058e on maoberlehner:master.

[bdwain]

@maoberlehner it seems to have just hung when trying to build on node 8, but the others were fine

[maoberlehner]

@bdwain thanks, I just restarted the CI build and it passed.

I'll take a closer look at this and most likely will merge it at on the weekend. Thanks for contributing!

[bdwain]

cool! thanks!

[maoberlehner]

The branch was merged locally and a new tag (5.2.0) was published to npm. Thank you very much for contributing!

[bdwain]

Awesome! Thanks for responding so quickly!