search

maoe / tkyprof

An interactive GHC profiling visualizer
https://hackage.haskell.org/package/tkyprof
Other
33 stars 4 forks source link

Port to Yesod 1.1 #31

Closed bgamari closed 11 years ago

bgamari commented 11 years ago

This is a quick port to Yesod 1.1. I'm not terribly familiar with Yesod, so I may have missed some of the more subtle points but the result nevertheless appears to function as expected. I made no attempt to maintain compatibility with previous Yesod versions and the lower version bounds are set fairly strictly as a result.

This also updates the profile parser to work against profiles produced by GHC 7.6. Moreover, the switch to attoparsec-conduit enables slightly more useful error messages when the parser does fail.

bgamari commented 11 years ago

Unfortunately I only spotted the feature/rework branch after finishing most of this work. What is the status of this branch?

maoe commented 11 years ago

Great! I'll take a look at your commits. As for the rework branch, I've stopped working on it.

maoe commented 11 years ago

Everything looked fine. I just merged it into master. Thanks :)