search

maoiscat / mpv-osc-modern

Another mpv osc script
GNU Lesser General Public License v2.1
333 stars 66 forks source link

Add option to toggle play/pause button #19

Closed Hill-98 closed 2 years ago

Hill-98 commented 2 years ago

I don't know why the triangle button is now showing while playing, but it doesn't fit most people's intuition.

I know it's possible to modify the script to toggle, but adding an option to toggle them I think would be nicer.

maoiscat commented 2 years ago

you can fork and realize such feature.

@.***

@.*** |

---- Replied Message ---- | From | Zhong @.> | | Date | 08/05/2022 02:12 | | To | @.> | | Cc | @.***> | | Subject | [maoiscat/mpv-osc-modern] Added option to toggle play/pause button (Issue #19) |

I don't know why the triangle button is now showing while playing, but it doesn't fit most people's intuition.

I know it's possible to modify the script to toggle, but adding an option to toggle them I think would be nicer.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Hill-98 commented 2 years ago

can i submit a pr?

maoiscat commented 2 years ago

sure

@.***

@.*** |

---- Replied Message ---- | From | Zhong @.> | | Date | 08/05/2022 12:23 | | To | @.> | | Cc | @.**@.> | | Subject | Re: [maoiscat/mpv-osc-modern] Add option to toggle play/pause button (Issue #19) |

can i submit a pr?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

Hill-98 commented 2 years ago

So can we set the default to show ⏸ when playing?

maoiscat commented 2 years ago

code is changed you have what you want