search

maorcc / citymind_water_meter

Home Assistant Integration with cp.city-mind.com, an Israeli water meters reading service
Apache License 2.0
41 stars 2 forks source link

Broken for Home Assistant 2021.6 #17

Closed maorcc closed 3 years ago

maorcc commented 3 years ago

This integration does not work with Home Assistant 2021.6. The following error is showing up in the log:

[custom_components.citymind_water_meter.managers.entity_manager] Failed to update, step: Start updating domain sensor, Error: 'sensor', Line: 167

elad-bar commented 3 years ago

Works for me, can you please post logs (with debug level)

Thanks

elad-bar commented 3 years ago

@maorcc, checked it once again, I'm running v1.0.0, so most probably it is related to v1.0.1 changes

Fannangir commented 3 years ago

Same issue here.

Logger: custom_components.citymind_water_meter.managers.entity_manager Source: custom_components/citymind_water_meter/managers/entity_manager.py:424 Failed to update, step: Start updating domain sensor, Error: 'sensor', Line: 167 V1.0.1

maorcc commented 3 years ago

@elad-bar, did you upgrade Home Assistant to 2021.6? Before I created the Citimind v1.0.1 release, it didn't load on 2021.6 because there was no version attribute in the manifest file. That's why I created the v1.0.1 release. I am not sure what's the cause of the new error. Maybe related to the minor changes that were done recently. @yuvalabou, can you have a look too?

Fannangir commented 3 years ago

Yes I did, HA 2021.6

elad-bar commented 3 years ago

@maorcc, i'm on 2021.6 + 1.0.0 (with local version key change) and it works, most probably changes of 1.0.1 led to it, will try to check it during the weekend

theone11 commented 3 years ago

I have the same error when running 1.0.1 on HA 2021.5.5. Reverted back to 1.0.0 and is working again.

rotem925 commented 3 years ago

I have the same issue with 1.0.1 and 2021.6 It seems broken on 2021.6

rotem925 commented 3 years ago

Just fixed it by rolling back to version 1.0.0, and setting the version manually in the manifest.json file.

yuvalabou commented 3 years ago

https://github.com/maorcc/citymind_water_meter/pull/18

elad-bar commented 3 years ago

Fixed in v1.0.2 by @yuvalabou, please update if it works, thanks

yuvalabou commented 3 years ago

Working as expected image