search

maorcc / citymind_water_meter

Home Assistant Integration with cp.city-mind.com, an Israeli water meters reading service
Apache License 2.0
40 stars 2 forks source link

Official integration #50

Open OnFreund opened 1 year ago

OnFreund commented 1 year ago

(originally started this as a discussion, but it doesn't look like discussions are active in this repo)

It seems like the new version is based on a JSON API, and does not employ any scraping like the old one. Given this, would it be possible to create an official integration and try to merge it into the HA codebase?

elad-bar commented 1 year ago

I think we should wait for the api to go official (end of the year), in addition, rename it to Read Your Meter Pro (as the company rebranded the solution) and then start talking about it, Let keep discussing it in discord if you would like to

OnFreund commented 1 year ago

sure, what's your username on discord?

elad-bar commented 1 year ago

In the discussion tab there is a link to the channel

OnFreund commented 1 year ago

You mean this one? https://github.com/maorcc/citymind_water_meter/discussions/46

It's expired

OnFreund commented 1 year ago

@elad-bar is there an update link? thanks!

elad-bar commented 1 year ago

Updated it

elad-bar commented 3 months ago

Hi @OnFreund @maorcc I conduct a major refactor to the component (v3.0.0), removed all the custom implementation to hide HA, now the component is much lighter, I also seperated the parts of communicating with RYMP API and added processors for account & meter to transform data into data model, I think with that approach it would be much easier to complete the transtion into official component.

also simplified the functionality of reteriving and changing the alert settings