search

maorfr / helm-backup

Helm plugin which performs backup/restore of releases in a namespace to/from a file
Other
83 stars 18 forks source link

Updates tiller-namespace flag and README.md #8

Closed miklezzzz closed 5 years ago

miklezzzz commented 5 years ago

Hi @maorfr, i spent some time digging around why your utility doesn't work when Tiller sits in a namespace other than "kube-system". It became obvious that --tiller-namespace flag can't be set for backup plugin itself because helm already has the same flag and doesn't want to share it with anyone else :). I propose to change the flag name to something like --tiller-ns or use short flag like "-t".

p.s. btw i changed SKIP_BIN_INSTALL to HELM_PUSH_PLUGIN_NO_INSTALL_HOOK in README.md coz first one doesn't work.

maorfr commented 5 years ago

hey @miklezzzz,

thanks a lot! i thought this might be the case.

thanks for this PR!