maoschanz / appfolders-manager-gnome-extension

A GNOME extension allowing easy management of "appfolders" directly from the applications grid.
GNU General Public License v3.0
94 stars 24 forks source link

allAppsGrid._grid is undefined #47

Closed alex285 closed 5 years ago

alex285 commented 5 years ago

it's on GNOME 3.31.2 so you need a Rawhide to debug that

JS ERROR: Exception in callback for signal: drag-begin: TypeError: allAppsGrid._grid is undefined
ensureFolderOverlayActors@/home/alex/.local/share/gnome-shell/extensions/appfolders-manager@maestroschan.fr/dragAndDrop.js:203:7
wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
on_drag_begin@/home/alex/.local/share/gnome-shell/extensions/appfolders-manager@maestroschan.fr/dragAndDrop.js:90:3
wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
initDND/injections._init2</<@/home/alex/.local/share/gnome-shell/extensions/appfolders-manager@maestroschan.fr/dragAndDrop.js:54:5
_emit@resource:///org/gnome/gjs/modules/signals.js:128:27
startDrag@resource:///org/gnome/shell/ui/dnd.js:285:9
wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
_maybeStartDrag@resource:///org/gnome/shell/ui/dnd.js:407:13
wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
_onEvent@resource:///org/gnome/shell/ui/dnd.js:236:24
wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
maoschanz commented 5 years ago

*alexa playing despacito in the background*

rip shell.genericcontainer

maoschanz commented 5 years ago

i don't have 3.31 so I don't know if what i just did fixes the issue

alex285 commented 5 years ago

nop it didn't! but i dont get any error logs this time. it just doesnt work

maoschanz commented 5 years ago

I installed GNOME Boxes just to test it with Fedora Rawhide and it works in the live session 🤔

alex285 commented 5 years ago

hmm? it does? :/ does live session have 3.31.2? you checked?

alex285 commented 5 years ago

I doubt, but maybe is some issue on Xorg only that I use, when live session logins you to Wayland?

maoschanz commented 5 years ago

i just installed the ISO, it works on both protocols, but it looks slower on Xorg (and for some reasons, when it's too slow, the drag begins when the click is released)

alex285 commented 5 years ago

and for some reasons, when it's too slow, the drag begins when the click is released

i can re-produce that :/

maoschanz commented 5 years ago

Better performance now, idk if it really fixes the issue

alex285 commented 5 years ago

it fixes the original issue, but it crashes like crazy :/

maoschanz commented 5 years ago

Not on my fedora rawhide VM, what are you using nowadays ?

maoschanz commented 5 years ago

(it has already been published on extensions.gnome.org so i hope you're the only one with crashes 😅)