search

maoschanz / emoji-selector-for-gnome

This extension provide a popup menu with some emojis ; clicking on an emoji copies it to the clipboard.
GNU General Public License v3.0
470 stars 76 forks source link

Update metadata.json #156

Closed soumyaDghosh closed 2 years ago

soumyaDghosh commented 2 years ago

Update the metadata.json file and add the "40" in the shell options. After that atleast the extension will work perfectly. Although still working on pref.ui

maoschanz commented 2 years ago

"perfectly" without the preferences? is this a joke? the extension is not compatible with gnome 3.40 yet so i'll not merge this, sorry

soumyaDghosh commented 2 years ago

On Sat, 2021-07-24 at 07:26 -0700, Romain F. T. wrote:

"perfectly" without the preferences? is this a joke? the extension is not compatible with gnome 3.40 yet so i'll not merge this, sorry — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. I'm Sorry if I have hurt you. But will you mind if I create a fork of your extension making it working in Gnome 40? Although it's kind of arrogance for a noob like me arguing with you. Forgive me for that. And also check the attachment. I'm using it, although without preferences.

maoschanz commented 2 years ago

you didn't hurt me don't worry. Pretending that broken things don't matter is just not the way we should distribute extensions

the very goal of the versions in the manifest file is that people will not encounter incompatible code, like the preferences window. If you want to use the extension anyway, it's up to you, the user aware of the risk of bugs, to disable the validation:

dconf write /org/gnome/shell/disable-extension-version-validation true

(at least this is the command with GNOME 3.38)

will you mind if I create a fork of your extension making it working in Gnome 40?

the fork compatible with GNOME 40 already exists, there is a pull request opened with it. But it's not compatible with any older GNOME Shell version including the one i use, so i can't merge it yet

soumyaDghosh commented 2 years ago

Can I have that extension for testing which is working in GNOME 40? And Thanks a lot for approvalSent using Zoho Mail ---- On Sun, 25 Jul 2021 09:29:25 +0530 @.*** wrote ---- you didn't hurt me don't worry. Pretending that broken things don't matter is just not the way we should distribute extensions the very goal of the versions in the manifest file is that people will not encounter incompatible code, like the preferences window. If you want to use the extension anyway, it's up to you, the user aware of the risk of bugs, to disable the validation: dconf write /org/gnome/shell/disable-extension-version-validation true

(at least this is the command with GNOME 3.38)

will you mind if I create a fork of your extension making it working in Gnome 40?

the fork compatible with GNOME 40 already exists, there is a pull request opened with it. But it's not compatible with any older GNOME Shell version including the one i use, so i can't merge it yet

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.