search

maoschanz / emoji-selector-for-gnome

This extension provide a popup menu with some emojis ; clicking on an emoji copies it to the clipboard.
GNU General Public License v3.0
475 stars 76 forks source link

Gnome 44 and search fix #186

Closed VortexAcherontic closed 2 months ago

VortexAcherontic commented 1 year ago

Add Gnome 44 to supported shell versions. Tested this on my local machine and found the extension to still function properly with Gnome 44. (With ❤️ from the Emoji Selector)

tim-hm commented 1 year ago

This is also working for me on gnome 44 (lunar lobster)

tim-hm commented 1 year ago

This no long appears to work on 44.rc. Logs and screen cast below.

Screencast from 2023-04-06 09-33-29.webm

JS ERROR: Exception in callback for signal: open-state-changed: TypeError: results.includes is not a function
searchEmoji@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiCategory.js:131:16
_getResults@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:116:36
_onSearchTextChanged@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:85:18
_onSearchTextChanged@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/extension.js:254:19
clearCategories@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/extension.js:249:8
_onOpenStateChanged@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/extension.js:151:8
_callHandlers@resource:///org/gnome/gjs/modules/core/_signals.js:130:42
_emit@resource:///org/gnome/gjs/modules/core/_signals.js:119:10
close@resource:///org/gnome/shell/ui/popupMenu.js:944:14
_onMenuOpenState@resource:///org/gnome/shell/ui/popupMenu.js:1351:27
_callHandlers@resource:///org/gnome/gjs/modules/core/_signals.js:130:42
_emit@resource:///org/gnome/gjs/modules/core/_signals.js:119:10
open@resource:///org/gnome/shell/ui/popupMenu.js:927:14
_changeMenu@resource:///org/gnome/shell/ui/popupMenu.js:1362:17
_onCapturedEvent@resource:///org/gnome/shell/ui/popupMenu.js:1386:22
VortexAcherontic commented 1 year ago

This no long appears to work on 44.rc. Logs and screen cast below.

JS ERROR: Exception in callback for signal: open-state-changed: TypeError: results.includes is not a function
searchEmoji@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiCategory.js:131:16
_getResults@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:116:36
_onSearchTextChanged@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/emojiSearchItem.js:85:18
_onSearchTextChanged@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/extension.js:254:19
clearCategories@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/extension.js:249:8
_onOpenStateChanged@/home/tim/.local/share/gnome-shell/extensions/emoji-selector@maestroschan.fr/extension.js:151:8
_callHandlers@resource:///org/gnome/gjs/modules/core/_signals.js:130:42
_emit@resource:///org/gnome/gjs/modules/core/_signals.js:119:10
close@resource:///org/gnome/shell/ui/popupMenu.js:944:14
_onMenuOpenState@resource:///org/gnome/shell/ui/popupMenu.js:1351:27
_callHandlers@resource:///org/gnome/gjs/modules/core/_signals.js:130:42
_emit@resource:///org/gnome/gjs/modules/core/_signals.js:119:10
open@resource:///org/gnome/shell/ui/popupMenu.js:927:14
_changeMenu@resource:///org/gnome/shell/ui/popupMenu.js:1362:17
_onCapturedEvent@resource:///org/gnome/shell/ui/popupMenu.js:1386:22

Found and fixed the issue. Changes are pending in this PR

rapenne-s commented 1 year ago

works for me, great job :ok_hand:

khaled-0 commented 1 year ago

bump @maoschanz please migrate to gnome44

RedAuburn commented 1 year ago

Works perfectly on Fedora 38, thanks!! @maoschanz please merge soon :)

Kalitsune commented 1 year ago

works for me as well, thx!

khaled-0 commented 1 year ago

This is getting very late now. I wonder if anything happened to the author.🙄 Hopefully he's alright

RedAuburn commented 1 year ago

sent an email, hopefully we can get an update :)

timreach commented 1 year ago

...he has made commits on other projects. Dude, please add some other people to help caretake this project if you are busy with other things :pray: this extension is too good :laughing:

rapenne-s commented 1 year ago

this must be the most approved PR on GitHub :partying_face:

VortexAcherontic commented 1 year ago

this must be the most approved PR on GitHub 🥳

Unfortunately GitHub has no badges for this 😂

VortexAcherontic commented 1 year ago

Hey @maoschanz this is a kind request to merge this PR. Or did I missed something which makes this merge an issue?

1e4 commented 1 year ago

Hey @maoschanz this is a kind request to merge this PR. Or did I missed something which makes this merge an issue?

Might be worth forking if you plan on maintaining it in the future, I don't think there are any plans for supporting this unless they only plan on supporting LTS

FelipeFTN commented 1 year ago

Hey @maoschanz this is a kind request to merge this PR. Or did I missed something which makes this merge an issue?

Might be worth forking if you plan on maintaining it in the future, I don't think there are any plans for supporting this unless they only plan on supporting LTS

I highly agree, but I don't know if would be possible to publish the same application into Gnome Extensions. But I'm available to fork and publish if possible.

timreach commented 1 year ago

Hey @maoschanz this is a kind request to merge this PR. Or did I missed something which makes this merge an issue?

Might be worth forking if you plan on maintaining it in the future, I don't think there are any plans for supporting this unless they only plan on supporting LTS

I highly agree, but I don't know if would be possible to publish the same application into Gnome Extensions. But I'm available to fork and publish if possible.

For it in a new extension dude, this is pretty much an abandoned project as it stands