maoschanz / emoji-selector-for-gnome

This extension provide a popup menu with some emojis ; clicking on an emoji copies it to the clipboard.
GNU General Public License v3.0
474 stars 76 forks source link

Use CLDR data for translations instead of manual #61

Open damienalexandre opened 5 years ago

damienalexandre commented 5 years ago

I see that search is based on some translations contributed here, this can lead to various problems:

But the thing is, Unicode and CLDR provides annotations for emoji in A LOT of languages, and for ALL emoji, in a easy to process format: https://www.unicode.org/repos/cldr/tags/release-34/common/annotations/en.xml

So I think this extension should rely on the official emoji annotation instead of trying to translate all emojis.

I do a bit of processing on the CLDR XML files here: https://github.com/jolicode/emoji-search - you can find Lucene formatted synonym files looking like this:

πŸ‘©β€πŸš’ => πŸ‘©β€πŸš’, firefighter, firetruck, woman
πŸ‘©β€βœˆ => πŸ‘©β€βœˆ, pilot, plane, woman
πŸ₯“ => πŸ₯“, bacon, meat, food
πŸ₯” => πŸ₯”, potato, vegetable, food
πŸ˜… => πŸ˜…, cold, face, open, smile, sweat
πŸ˜† => πŸ˜†, face, laugh, mouth, open, satisfied, smile
🚎 => 🚎, bus, tram, trolley
πŸ‡«πŸ‡· => πŸ‡«πŸ‡·, france
πŸ‡¬πŸ‡§ => πŸ‡¬πŸ‡§, united kingdom

Or just replace /update-and-compile-translations.sh with a new logic.

Cheers.

maoschanz commented 5 years ago

search is based on some translations contributed here

bold of you to assume these contributions exist, iirc there is only the french one from me, and maybe italian but i haven't taken the time to merge it yet, but they are mainly copy-paste of these CLDR data.

There are 2 issues here:

Using these data would need an rewrite of half of the code, it's unlikely that i take time to do it while i'm still playing with my very cool Paint clone.

Or just replace /update-and-compile-translations.sh with a new logic.

Not "replace", this extension will still needs string other than keywords for searching emojis

amivaleo commented 5 years ago

[ot]

Using these data would need an rewrite of half of the code, it's unlikely that i take time to do it while i'm still playing with my very cool Paint clone.

Sorry for bothering here. Github has no private messaging so I didn't know how/where to say this: that project is AMAZING. Thank you SO MUCH for working on that. :o

[/ot]

damienalexandre commented 5 years ago

You know this is only a suggestion for enhancement and not a criticism or a personal attack? The tone of your response feels angry to me and I was not expecting that. Be sure I'm not here to give orders or ask for anything, I love this extension and use it daily on my computer. I know this can't be done that easily and if you don't want / don't have the time, that's no problem. Sorry for my poor choice of words that may have caused some confusion :heart:

To get back to the suggestion

IMO the interface translations and the emoji search mechanism could be separated, and the benefits will be a broader / more complete search experience for users.

Yes as you say this will greatly impact the extension.

If you think this is a bad idea feel free to close.

Cheers.

maoschanz commented 5 years ago

You know this is only a suggestion for enhancement and not a criticism or a personal attack?

Yes i know, but i feel like i have to explain why i will not do it right now despite the fact it's a very good idea