search

maotoumao / MusicFreeDesktop

插件化、定制化、无广告的免费音乐播放器
http://musicfree.upup.fun/
GNU General Public License v3.0
2.35k stars 224 forks source link

How to put in English? #100

Closed peter9811 closed 3 weeks ago

peter9811 commented 3 months ago

Is possible a option to put the interface on English?

Thanks

maotoumao commented 3 months ago

Certainly, I'll do it in the next few weeks :)

peter9811 commented 3 months ago

Thanks. And I can help to do it in Spanish if you'd like

maotoumao commented 3 months ago

That would be great! I'll set up the i18n first and then I'll let you know how to add languages.

Thank you for offering your help😀

peter9811 commented 3 months ago

Perfect. I'll be happy to help

And I have a question, because I didn't really tried too much (language barrier): it's possible like take the library (the local one (already downloaded mp3)) and check if there is a better version and download it? If not could be possible implement it a future?

maotoumao commented 3 months ago

Good idea!

There has not been such a feature so far, but I think it's better to provide a shortcut entry to search for the same song on different platforms, and let the users decide which result is better than the local one themselves.

And allow me to provide a bit more clarification. You can think of this software (MusicFree) as a shell that only defines the framework of what a music player should have.

MusicFree doesn't integrate any media resources, instead, it abstracts the specifics of how to obtain music and how to search it into plugins, which are related to particular platforms. So in theory, you could play music from any platform you can search in the web by installing the appropriate plugins, and a plugin itself is just a simple commonjs module.

Therefore, I think that it's difficult to let the software decide which music quality is better, maybe it's better to leave the choice to users.

peter9811 commented 3 months ago

Yes. I understand about the plugins, but I mean, for example if I have 128 kb/s and the software found a 320 kb/s from Netease and just download automatically all the "upgraded" version of the MP3 merging the metadata and all the stuff

Because, can be used like local player too?

maotoumao commented 3 months ago

Sorry for late reply.

Got it, so it is expected that there would be an option for something like "auto upgrade local version", and the software should periodically check if there are better versions of local music available.

Is my understanding correct? 😄

peter9811 commented 3 months ago

Something like that would be awesome Thanks

maotoumao commented 3 weeks ago

Hi @peter9811, I've released a new version with i18n. You can try the v0.0.4 here.

English and Spanish were added with the help of ChatGPT, and feel free to correct me if there's any bad translation.

peter9811 commented 3 weeks ago

@maotoumao Sounds great. I'm going to work, when I come back I'll have a look into to check if everything is okay. Thanks