Should applicationName be stored in AllXml?

maoyuan121 / elmah

Automatically exported from code.google.com/p/elmah

Apache License 2.0

0 stars 0 forks source link

Should applicationName be stored in AllXml? #244

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

I noticed that you have code in ErrorXml.cs:217 that looks to write the 
error.ApplicationName to the xml string. But, as far as i could tell, the value 
of error.ApplicationName is never set.

Should it be set? Maybe around SqlErrorLog.cs:141. Something like:
error.ApplicationName = ApplicationName;

Original issue reported on code.google.com by smagli...@gmail.com on 4 Aug 2011 at 6:07

GoogleCodeExporter commented 9 years ago

Original comment by azizatif on 18 Dec 2011 at 7:10

Changed state: Accepted
Added labels: Component-Persistence, Type-Defect
Removed labels: Type-Enhancement

GoogleCodeExporter commented 9 years ago

Original comment by azizatif on 18 Dec 2011 at 7:17

Changed state: Started
Added labels: Milestone-Release1.2SP1, Priority-Critical
Removed labels: Priority-Medium

GoogleCodeExporter commented 9 years ago

This issue was closed by revision r912.

Original comment by azizatif on 18 Dec 2011 at 7:27

Changed state: Fixed