Review required fields and types

map-egypt / admin

https://map-egypt.github.io/admin/

Other

0 stars 3 forks source link

Review required fields and types #122

Open kamicut opened 7 years ago

kamicut commented 7 years ago

We have received feedback that:

some fields that are non-required are triggering as required and preventing form submission
some fields are triggering type errors (e.g number of beneficiaries is asking for a number even though a number is entered)
draft mode sometimes doesn't work when omitting required fields

We should go over the fields and make sure there aren't any inconsistencies in field requirements cc @sethvincent @felskia

kamicut commented 7 years ago

I think these are fixed with #124

We could go over all the combination of fields but I think that doesn't scale. We could figure out a minimal test suite that can cover some of the expected behavior. It could be a small or a huge lift but I don't have experience with browser form testing. What do you think @sethvincent?