search

map-egypt / map-egypt.github.io

Other
1 stars 6 forks source link

Changing the date to be Month/Day/Year #313

Closed felskia closed 7 years ago

felskia commented 7 years ago

All dates on the site

drewbo commented 7 years ago

@felskia can we not make them in that format? it's confusing for international audiences

felskia commented 7 years ago

@drewbo good catch. It's actually supposed to be the opposite and that was is currently confusing for the Egyptian folks. Which is the reason for the ticket.

nbumbarger commented 7 years ago

The date is currently set to render according to a users' location profile from their browser. People in the US should get m/d/yyyy while people with Arabic settings should get yyyy/m/d- but this will only work if their preferences are configured for it.

If it doesn't seem to be working for the audience, I could force the Arabic version of the site (or both versions) into always using yyyy/m/d.

felskia commented 7 years ago

@nbumbarger I would say always force it to this other format. No one in the US will be using this tool so having the day month year format will be better for the English speakers who will use it too.

nbumbarger commented 7 years ago

Sounds good, this PR now changes the date in both views.