search

map-egypt / map-egypt.github.io

Other
1 stars 6 forks source link

close #313; force Arabic date format when in Arabic view #316

Closed nbumbarger closed 7 years ago

nbumbarger commented 7 years ago

Defaulting to locale-based date format only works when the browser's locale is set. This fix forces Arabic date formatting when the Arabic view is turned on, regardless of user settings.

felskia commented 7 years ago

@nbumbarger so it still looks wrong. Looks like it's year, month, day?

screen shot 2017-04-06 at 3 38 54 pm
nbumbarger commented 7 years ago

@felskia yes, that's the format I read was preferred in Arabic. Did you want yyyy/d/m?

felskia commented 7 years ago

@nbumbarger that is because it's right to left. So on the English side it would be: dd/mm/yyyy and on the Arabic side it would be yyyy/mm/dd

nbumbarger commented 7 years ago

The latest change makes it so that the Arabic and English views always show dates as yyyy/d/m and the English view m/d/yyyy, respectively.

felskia commented 7 years ago

@nbumbarger sorry for the confusion here. The problem now is that it's back to what it was. Day should be first. So it should be:

English: Day/Month/Year Arabic: Year/Month/Day

nbumbarger commented 7 years ago

updated