Closed felskia closed 6 years ago
The API is not returning categories in arabic, @kamicut can you look to see why? Without Arabic categories there's no way to group the indicators. It also seems that the indicator names are coming in only English.
@dereklieu I'm correcting the arabic names in the API now. By categories do you mean themes? There are two types of "categories", the "type" of the indicator (sequential, diverging, categorical), and the "theme": "Economy", "Agriculture", which has the type "other", but also SDS and SDG indicators.
@felskia @dereklieu
The labels.js
label file that is in the admin does not contain the proper translation for themes. There are 2 missing translations for the SDS indicators, and no translations for SDG and "other" themes. We need these translations to render them in the frontend.
@dereklieu I've added the missing translations to the labels file. Could you check if this is enough to continue work on this ticket?
@kamicut Not yet, the name_ar
and description_ar
fields in this response are still null:
@dereklieu that's a data entry mistake by the data team. There are some indicators (for example "Rice Production - 2010") that do have entries. Could we filter out the nulls?
It is filtering out the nulls, the problem is most of them are null, which is how we get the display at the top of this ticket.
@felskia it looks like this is data-entry related, the arabic names aren't getting inputted into the api somehow.
So this would be a @kamicut problem? We keep getting pinged by them since these little changes have taken us a while. Is there anyway the two of you can wrap these things up this week or beginning of next?
@dereklieu
Closed #352
Right now it says 0 but there are a bunch.