map-egypt / map-egypt.github.io

Other
1 stars 6 forks source link

Indicator names show up in English on the map as well #347

Closed felskia closed 6 years ago

felskia commented 7 years ago
screen shot 2017-08-14 at 4 18 21 pm
felskia commented 6 years ago

@dereklieu this one is still happening too. Even though some of the names are translated in the backend.

dereklieu commented 6 years ago

After #356 you can add indicators in Arabic and they'll show up as Arabic everywhere.

If you add an Arabic indicator then toggle to English, the Arabic indicator will still be shown, and vice versa.

demo2

This isn't ideal but should be fine, the regular user will choose one language and won't be toggling back and forth.

felskia commented 6 years ago

@dereklieu this section isn't working for me in Arabic and also, these still show up in English...

screen shot 2017-11-13 at 1 54 12 pm