search

map-egypt / map-egypt.github.io

Other
1 stars 6 forks source link

Display of no data #348

Open felskia opened 7 years ago

felskia commented 7 years ago

In the display of indicators, sometimes when there is no data for some governorates, it displays as zero not “no data”, although it used to be the case that it displayed as “no data”. Please see attached snapshot: there are 2 zeros in the legend at the bottom, with 2 different colors: one is for the no data, and one is for the observations with 0 in them.

0 no data

dereklieu commented 7 years ago

@felskia These regions do have data, but two 0's are showing because over 2/5ths of the regions don't produce any rice. These are quantile scales, so the values are sorted and then separated into equal groups of 5. If more than 2/5ths of the regions have 0 for their rice production, then the scale will assign two groups as 0-0. The no data legend item should still come up when there's no data at all.

The code is behaving right and it's accurately representing the data, but it's resulting in a slightly confusing display. I think in this case there should be documentation and training, so that users understand that this is a possible outcome of using a quantile scale.