search

mapa17 / Eruliaf

A BitTorrent like overlay peer simulator
GNU General Public License v3.0
1 stars 0 forks source link

Too high upload #51

Closed mapa17 closed 12 years ago

mapa17 commented 12 years ago

Since adding to the PeerC1 node an adaptive scheduling of number of OU and TFT slots, as mentioned in #50, the PeerC1 sometimes upload more than their maximum upload rate.

mapa17 commented 12 years ago

First investigations have made clear that TFT Slots have been used although the maximum number of TFT slots was set to zero. This was because of optimization in the PeerC1.runTFT() algorithm that returned when there were no TFT slots to be scheduled. This caused already scheduled slots to not be removed. Meaning that if maxTFT Slots was once bigger than zero and than is set to zero, the already scheduled TFT slots stay as they are, buy because TFTMax is set to zero, the ou slots can get the total upload bandwidth.

Fixing this still did not prevent a too high upload....

mapa17 commented 12 years ago

Going through the code again, the same problem was in the peer and in some other parts of the runOU and runTFT code. It should work fine now. Closing the issue with the next commit.