search

mapa17 / Eruliaf

A BitTorrent like overlay peer simulator
GNU General Public License v3.0
1 stars 0 forks source link

Uninterested Peers beeing drop from OU Slot #61

Closed mapa17 closed 12 years ago

mapa17 commented 12 years ago

Peers that have been sheduled for OU are beeing dropped if they, even for a single tick are not interested. This is not how OU should work!

Maybe there is something wrong int he updateLocalConnection state, or updateGlobalConnectionState ...

mapa17 commented 12 years ago

The same happens to peers in TFT Slots! This is a real problem for PeerC1 in a state of high piece Availability and a high number of TFT Slots.

I just cant find any part of the program that actively drops uninterested Peers ...

mapa17 commented 12 years ago

One reason for peers changing from active OU or TFT to inactive seems to be because they reconnect from the remote peer and be default new connections are not interesting. ( they get updated in the GlobalConnectionUpdate )

This could be fixed in the PeerC1._dropPeer() function. This is the same problem as described in issue #62

mapa17 commented 12 years ago

Another reason for this is the implicit synchronization of peers. It just happens (at the beginning at least) that peers drop others they would have scheduled them far too often.