search

mapaction / mapaction-toolbox

A collection of tools to help streamline the process of producing maps including data renaming and map exports.
GNU General Public License v3.0
3 stars 1 forks source link

change from element mxd_name to element map_name #182

Closed clairebyrne closed 4 years ago

clairebyrne commented 4 years ago

Expected Behavior

The templates now have a text element with the more generic name of map_name instead of mxd_name. This is to allow for QGIS and Pro scenarios. The layout tool should be changed to use map_name element instead of mxd_name. The element checker should be updated similarly. In the output XML, the Export tool should create an xml tag called mapfilename, instead of mxdfilename

Actual Behavior

The layout tool currently updates the text element mxd_name for the Map Document, and pulls the value from the file name. In the output XML, the Export tool creates an xml tag called mxdfilename.

Steps to Reproduce the Problem

1. 2. 3.

Specifications

harry-gibson commented 4 years ago

The map_name element is not visible on the layout of any template. We (@harry-gibson @clairebyrne @dconnaghanx ) therefore see no reason to use it at all. The mapfilename tag in the xml will now be populated with the actual filename of the mxd (and this will be shown, readonly, in the export dialog). It will be removed from the Layout tool. The xml also contains a ref tag which appears to be (and will continue to be) a duplicate of mapfilename (previously of mxdfilename)

harry-gibson commented 4 years ago

Issue is fixed, re-open if any complaints ensue due to the new fixed relationship between mxd filename and value in xml